fix(settings): make recommended model one click and prefer on-disk - #781
Draft
jatinkrmalik wants to merge 3 commits into
Draft
fix(settings): make recommended model one click and prefer on-disk#781jatinkrmalik wants to merge 3 commits into
jatinkrmalik wants to merge 3 commits into
Conversation
The Speech Model panel printed a recommended size and specialization as plain text, so applying it meant hunting through two dropdowns. Turning that line into a button sets both at once. Before a download starts, whisper.cpp now checks for a same-size weight already on disk and offers it. The Model Size list also shows weight and a downloaded marker the way Specialization already does. Fixes #778
✅ Deploy Preview for voca-linux canceled.
|
github-actions
Bot
added
app
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
jatinkrmalik
marked this pull request as ready for review
September 5, 2026 19:23
|
| Filename | Overview |
|---|---|
| src/vocalinux/ui/settings_dialog.py | Implements recommendation actions, model-size status labels, and comparable on-disk model selection; two new handlers omit repository-required return annotations. |
| tests/test_recommended_model_action.py | Adds focused unit coverage for the recommendation and on-disk model-selection helpers and UI routing. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User selects whisper.cpp model] --> B{Requested model downloaded?}
B -- Yes --> F[Apply and save settings]
B -- No --> C{Same-size compatible model on disk?}
C -- No --> D[Begin requested-model download]
C -- Yes --> E{User choice}
E -- Use on-disk --> F
E -- Download --> D
E -- Cancel --> G[Restore saved model UI]
D --> F
Reviews (1): Last reviewed commit: "fix(settings): make recommended model on..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Greptile flagged the two new helpers for missing return types.
jatinkrmalik
marked this pull request as draft
September 5, 2026 19:44
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Speech Model showed a recommended model as a dead label. You had to map "Small EN" onto Model Size and Specialization yourself, and it was easy to download a fresh weight when a same-size one was already local.
Test plan
pytest tests/test_recommended_model_action.pyFixes #778
Known limits
Comparable on-disk means the same size bucket only (not a larger leftover like Medium when Small is recommended). English-only leftovers are not offered when the language is not English.